grover without dynamicsupervisor?

.credo.exs

@@ -0,0 +1,217 @@
+# This file contains the configuration for Credo and you are probably reading
+# this after creating it with `mix credo.gen.config`.
+#
+# If you find anything wrong or unclear in this file, please report an
+# issue on GitHub: https://github.com/rrrene/credo/issues
+#
+%{
+  #
+  # You can have as many configs as you like in the `configs:` field.
+  configs: [
+    %{
+      #
+      # Run any config using `mix credo -C <name>`. If no config name is given
+      # "default" is used.
+      #
+      name: "default",
+      #
+      # These are the files included in the analysis:
+      files: %{
+        #
+        # You can give explicit globs or simply directories.
+        # In the latter case `**/*.{ex,exs}` will be used.
+        #
+        included: [
+          "lib/",
+          "src/",
+          "test/",
+          "web/",
+          "apps/*/lib/",
+          "apps/*/src/",
+          "apps/*/test/",
+          "apps/*/web/"
+        ],
+        excluded: [~r"/_build/", ~r"/deps/", ~r"/node_modules/"]
+      },
+      #
+      # Load and configure plugins here:
+      #
+      plugins: [],
+      #
+      # If you create your own checks, you must specify the source files for
+      # them here, so they can be loaded by Credo before running the analysis.
+      #
+      requires: [],
+      #
+      # If you want to enforce a style guide and need a more traditional linting
+      # experience, you can change `strict` to `true` below:
+      #
+      strict: true,
+      #
+      # To modify the timeout for parsing files, change this value:
+      #
+      parse_timeout: 5000,
+      #
+      # If you want to use uncolored output by default, you can change `color`
+      # to `false` below:
+      #
+      color: true,
+      #
+      # You can customize the parameters of any check by adding a second element
+      # to the tuple.
+      #
+      # To disable a check put `false` as second element:
+      #
+      #     {Credo.Check.Design.DuplicatedCode, false}
+      #
+      checks: %{
+        enabled: [
+          #
+          ## Consistency Checks
+          #
+          {Credo.Check.Consistency.ExceptionNames, []},
+          {Credo.Check.Consistency.LineEndings, []},
+          {Credo.Check.Consistency.ParameterPatternMatching, []},
+          {Credo.Check.Consistency.SpaceAroundOperators, []},
+          {Credo.Check.Consistency.SpaceInParentheses, []},
+          {Credo.Check.Consistency.TabsOrSpaces, []},
+
+          #
+          ## Design Checks
+          #
+          # You can customize the priority of any check
+          # Priority values are: `low, normal, high, higher`
+          #
+          {Credo.Check.Design.AliasUsage,
+           [priority: :low, if_nested_deeper_than: 2, if_called_more_often_than: 0]},
+          {Credo.Check.Design.TagFIXME, []},
+          # You can also customize the exit_status of each check.
+          # If you don't want TODO comments to cause `mix credo` to fail, just
+          # set this value to 0 (zero).
+          #
+          {Credo.Check.Design.TagTODO, [exit_status: 2]},
+
+          #
+          ## Readability Checks
+          #
+          {Credo.Check.Readability.AliasOrder, []},
+          {Credo.Check.Readability.FunctionNames, []},
+          {Credo.Check.Readability.LargeNumbers, []},
+          {Credo.Check.Readability.MaxLineLength, [priority: :low, max_length: 120]},
+          {Credo.Check.Readability.ModuleAttributeNames, []},
+          {Credo.Check.Readability.ModuleDoc, []},
+          {Credo.Check.Readability.ModuleNames, []},
+          {Credo.Check.Readability.ParenthesesInCondition, []},
+          {Credo.Check.Readability.ParenthesesOnZeroArityDefs, []},
+          {Credo.Check.Readability.PipeIntoAnonymousFunctions, []},
+          {Credo.Check.Readability.PredicateFunctionNames, []},
+          {Credo.Check.Readability.PreferImplicitTry, []},
+          {Credo.Check.Readability.RedundantBlankLines, []},
+          {Credo.Check.Readability.Semicolons, []},
+          {Credo.Check.Readability.SpaceAfterCommas, []},
+          {Credo.Check.Readability.StringSigils, []},
+          {Credo.Check.Readability.TrailingBlankLine, []},
+          {Credo.Check.Readability.TrailingWhiteSpace, []},
+          {Credo.Check.Readability.UnnecessaryAliasExpansion, []},
+          {Credo.Check.Readability.VariableNames, []},
+          {Credo.Check.Readability.WithSingleClause, []},
+
+          #
+          ## Refactoring Opportunities
+          #
+          {Credo.Check.Refactor.Apply, []},
+          {Credo.Check.Refactor.CondStatements, []},
+          {Credo.Check.Refactor.CyclomaticComplexity, []},
+          {Credo.Check.Refactor.FilterCount, []},
+          {Credo.Check.Refactor.FilterFilter, []},
+          {Credo.Check.Refactor.FunctionArity, []},
+          {Credo.Check.Refactor.LongQuoteBlocks, []},
+          {Credo.Check.Refactor.MapJoin, []},
+          {Credo.Check.Refactor.MatchInCondition, []},
+          {Credo.Check.Refactor.NegatedConditionsInUnless, []},
+          {Credo.Check.Refactor.NegatedConditionsWithElse, []},
+          {Credo.Check.Refactor.Nesting, []},
+          {Credo.Check.Refactor.RedundantWithClauseResult, []},
+          {Credo.Check.Refactor.RejectReject, []},
+          {Credo.Check.Refactor.UnlessWithElse, []},
+          {Credo.Check.Refactor.WithClauses, []},
+
+          #
+          ## Warnings
+          #
+          {Credo.Check.Warning.ApplicationConfigInModuleAttribute, []},
+          {Credo.Check.Warning.BoolOperationOnSameValues, []},
+          {Credo.Check.Warning.Dbg, []},
+          {Credo.Check.Warning.ExpensiveEmptyEnumCheck, []},
+          {Credo.Check.Warning.IExPry, []},
+          {Credo.Check.Warning.IoInspect, []},
+          {Credo.Check.Warning.MissedMetadataKeyInLoggerConfig, []},
+          {Credo.Check.Warning.OperationOnSameValues, []},
+          {Credo.Check.Warning.OperationWithConstantResult, []},
+          {Credo.Check.Warning.RaiseInsideRescue, []},
+          {Credo.Check.Warning.SpecWithStruct, []},
+          {Credo.Check.Warning.UnsafeExec, []},
+          {Credo.Check.Warning.UnusedEnumOperation, []},
+          {Credo.Check.Warning.UnusedFileOperation, []},
+          {Credo.Check.Warning.UnusedKeywordOperation, []},
+          {Credo.Check.Warning.UnusedListOperation, []},
+          {Credo.Check.Warning.UnusedPathOperation, []},
+          {Credo.Check.Warning.UnusedRegexOperation, []},
+          {Credo.Check.Warning.UnusedStringOperation, []},
+          {Credo.Check.Warning.UnusedTupleOperation, []},
+          {Credo.Check.Warning.WrongTestFileExtension, []}
+        ],
+        disabled: [
+          #
+          # Checks scheduled for next check update (opt-in for now)
+          {Credo.Check.Refactor.UtcNowTruncate, []},
+
+          #
+          # Controversial and experimental checks (opt-in, just move the check to `:enabled`
+          #   and be sure to use `mix credo --strict` to see low priority checks)
+          #
+          {Credo.Check.Consistency.MultiAliasImportRequireUse, []},
+          {Credo.Check.Consistency.UnusedVariableNames, []},
+          {Credo.Check.Design.DuplicatedCode, []},
+          {Credo.Check.Design.SkipTestWithoutComment, []},
+          {Credo.Check.Readability.AliasAs, []},
+          {Credo.Check.Readability.BlockPipe, []},
+          {Credo.Check.Readability.ImplTrue, []},
+          {Credo.Check.Readability.MultiAlias, []},
+          {Credo.Check.Readability.NestedFunctionCalls, []},
+          {Credo.Check.Readability.OneArityFunctionInPipe, []},
+          {Credo.Check.Readability.OnePipePerLine, []},
+          {Credo.Check.Readability.SeparateAliasRequire, []},
+          {Credo.Check.Readability.SingleFunctionToBlockPipe, []},
+          {Credo.Check.Readability.SinglePipe, []},
+          {Credo.Check.Readability.Specs, []},
+          {Credo.Check.Readability.StrictModuleLayout, []},
+          {Credo.Check.Readability.WithCustomTaggedTuple, []},
+          {Credo.Check.Refactor.ABCSize, []},
+          {Credo.Check.Refactor.AppendSingleItem, []},
+          {Credo.Check.Refactor.DoubleBooleanNegation, []},
+          {Credo.Check.Refactor.FilterReject, []},
+          {Credo.Check.Refactor.IoPuts, []},
+          {Credo.Check.Refactor.MapMap, []},
+          {Credo.Check.Refactor.ModuleDependencies, []},
+          {Credo.Check.Refactor.NegatedIsNil, []},
+          {Credo.Check.Refactor.PassAsyncInTestCases, []},
+          {Credo.Check.Refactor.PipeChainStart, []},
+          {Credo.Check.Refactor.RejectFilter, []},
+          {Credo.Check.Refactor.VariableRebinding, []},
+          {Credo.Check.Warning.LazyLogging, []},
+          {Credo.Check.Warning.LeakyEnvironment, []},
+          {Credo.Check.Warning.MapGetUnsafePass, []},
+          {Credo.Check.Warning.MixEnv, []},
+          {Credo.Check.Warning.UnsafeToAtom, []}
+
+          # {Credo.Check.Refactor.MapInto, []},
+
+          #
+          # Custom checks can be created using `mix credo.gen.check`.
+          #
+        ]
+      }
+    }
+  ]
+}

lib/something_erlang/awful_api/bookmarks.ex

@@ -38,7 +38,11 @@ defmodule SomethingErlang.AwfulApi.Bookmarks do
     info = Meeseeks.one(td, css(".info"))
 
     %{
-      new_posts: Meeseeks.text(last_seen) |> String.to_integer(),
+      new_posts:
+        case Meeseeks.text(last_seen) do
+          nil -> 0
+          n -> String.to_integer(n)
+        end,
       thread_title: Meeseeks.text(Meeseeks.one(info, css(".thread_title")))
     }
   end

lib/something_erlang/awful_api/thread.ex

@@ -111,7 +111,11 @@ defmodule SomethingErlang.AwfulApi.Thread do
     if class == "sa-smilie" do
       {"img", attrs, []}
     else
-      t_attrs = List.keyreplace(attrs, "class", 0, {"class", "img-responsive"})
+      t_attrs =
+        attrs
+        |> fix_attachment_links()
+        |> List.keyreplace("class", 0, {"class", "img-responsive"})
+
       {"img", [{"loading", "lazy"} | t_attrs], []}
     end
   end
@@ -194,4 +198,15 @@ defmodule SomethingErlang.AwfulApi.Thread do
             {"src", src}
           ], []}
        ]}
+
+  defp fix_attachment_links(attrs) do
+    {"src", src} = List.keyfind(attrs, "src", 0)
+
+    if String.starts_with?(src, "attachment.php") do
+      List.keyreplace(attrs, "src", 0, {"src", "https://forums.somethingawful.com/" <> src})
+      |> List.keydelete("alt", 0)
+    else
+      attrs
+    end
+  end
 end

lib/something_erlang/grover.ex

@@ -4,48 +4,30 @@ defmodule SomethingErlang.Grover do
   alias SomethingErlang.AwfulApi
   require Logger
 
-  def mount(user) do
-    grover =
-      DynamicSupervisor.start_child(
-        SomethingErlang.Supervisor.Grovers,
-        {__MODULE__, [self(), user]}
-      )
-
-    case grover do
-      {:ok, pid} -> pid
-      {:error, {:already_started, pid}} -> pid
-      {:error, error} -> {:error, error}
-    end
-  end
-
   def get_thread!(thread_id, page_number) do
-    GenServer.call(via(self()), {:show_thread, thread_id, page_number})
+    GenServer.call(__MODULE__, {:show_thread, thread_id, page_number})
   end
 
-  def get_bookmarks!(page_number) do
+  def get_bookmarks!(pid, page_number) do
-    GenServer.call(via(self()), {:show_bookmarks, page_number})
+    GenServer.call(pid, {:show_bookmarks, page_number})
   end
 
-  def start_link([lv_pid, user]) do
+  def start_link(user) do
     GenServer.start_link(
       __MODULE__,
-      [lv_pid, user],
+      [user]
-      name: via(lv_pid)
     )
   end
 
   @impl true
-  def init([pid, user]) do
+  def init([user]) do
     %{bbuserid: userid, bbpassword: userhash} = user
 
     initial_state = %{
-      lv_pid: pid,
       user: %{id: userid, hash: userhash}
     }
 
-    Logger.debug("init #{userid} #{inspect(pid)}")
+    {:ok, initial_state} |> dbg()
-    Process.monitor(pid)
-    {:ok, initial_state}
   end
 
   @impl true
@@ -57,20 +39,6 @@ defmodule SomethingErlang.Grover do
   @impl true
   def handle_call({:show_bookmarks, page_number}, _from, state) do
     bookmarks = AwfulApi.bookmarks(page_number, state.user)
-    {:reply, bookmarks, state}
+    {:reply, bookmarks, state} |> dbg()
   end
-
-  @impl true
-  def handle_info({:DOWN, _ref, :process, _object, reason}, state) do
-    Logger.debug("received :DOWN from: #{inspect(state.lv_pid)} reason: #{inspect(reason)}")
-
-    case reason do
-      {:shutdown, _} -> {:stop, :normal, state}
-      :killed -> {:stop, :normal, state}
-      _ -> {:noreply, state}
-    end
-  end
-
-  defp via(lv_pid),
-    do: {:via, Registry, {SomethingErlang.Registry.Grovers, lv_pid}}
 end

lib/something_erlang_web/live/bookmarks_live.ex

@@ -4,10 +4,12 @@ defmodule SomethingErlangWeb.BookmarksLive do
   alias SomethingErlang.Grover
 
   def render(assigns) do
+    assigns.bookmarks |> dbg()
+
     ~H"""
-    <div :if={@bookmarks}>
+    <div :if={bookmarks = @bookmarks.ok? && @bookmarks.result}>
       <.bookmark
-        :for={thread <- @bookmarks}
+        :for={thread <- bookmarks}
         id={thread.id}
         title={thread.title.thread_title}
         post_count={thread.replies}
@@ -17,7 +19,7 @@ defmodule SomethingErlangWeb.BookmarksLive do
   end
 
   defp bookmark(assigns) do
-    assigns = assign(assigns, :pages, trunc(assigns.post_count / 40))
+    assigns = assign(assigns, :pages, ceil(assigns.post_count / 40))
 
     ~H"""
     <div>
@@ -32,11 +34,21 @@ defmodule SomethingErlangWeb.BookmarksLive do
       socket.assigns.current_user
       |> Map.put(:bbpassword, session["bbpassword"])
 
-    Grover.mount(user)
+    {:ok, pid} = Grover.start_link(user) |> dbg()
 
     {:ok,
      socket
      |> assign(:page_title, "Bookmarks")
-     |> assign(:bookmarks, Grover.get_bookmarks!(1) |> dbg())}
+     |> assign_async(:bookmarks, fn ->
+       {:ok, bookmarks} = get_bookmarks(pid)
+       {:ok, %{bookmarks: bookmarks}}
+     end)}
+  end
+
+  defp get_bookmarks(pid) do
+    case Grover.get_bookmarks!(pid, 1) do
+      bookmarks when is_list(bookmarks) -> {:ok, bookmarks}
+      _ -> {:error, "Failed getting bookmarks"}
+    end
   end
 end

lib/something_erlang_web/live/thread_live.ex

@@ -69,10 +69,10 @@ defmodule SomethingErlangWeb.ThreadLive do
     ~H"""
     <div class="navbar my-4 bg-base-200">
       <div class="flex-1"></div>
-      <div class="pagination flex-none btn-group grid grid-cols-5">
+      <div class="pagination join">
         <%= for btn <- buttons(@thread) do %>
           <.link
-            class={["btn btn-sm btn-ghost", btn.special]}
+            class={["btn btn-sm btn-ghost join-item", btn.special]}
             navigate={~p"/thread/#{@thread.id}?page=#{btn.page}"}
           >
             <.label_button label={btn.label} page={btn.page} />
@@ -86,8 +86,8 @@ defmodule SomethingErlangWeb.ThreadLive do
   defp label_button(%{label: label} = assigns) do
     case label do
       "«" -> ~H{<.icon name="hero-chevron-double-left-mini" /><%= @page %>}
-      "‹" -> ~H{<.icon name="hero-chevron-left-mini" /><%= @page %>}
+      "‹" -> ~H{<.icon name="hero-chevron-left-mini" />}
-      "›" -> ~H{<%= @page %><.icon name="hero-chevron-right-mini" />}
+      "›" -> ~H{<.icon name="hero-chevron-right-mini" />}
       "»" -> ~H{<%= @page %><.icon name="hero-chevron-double-right-mini" />}
       _ -> ~H{<%= @page %>}
     end

mix.exs

@@ -59,7 +59,8 @@ defmodule SomethingErlang.MixProject do
       {:dns_cluster, "~> 0.1.1"},
       {:bandit, "~> 1.2"},
       {:meeseeks, "~> 0.17.0"},
-      {:req, "~> 0.5.0"}
+      {:req, "~> 0.5.0"},
+      {:credo, "~> 1.7", only: [:dev, :test], runtime: false}
     ]
   end
 

mix.lock

@@ -1,6 +1,8 @@
 %{
   "bandit": {:hex, :bandit, "1.5.2", "ed0a41c43a9e529c670d0fd48371db4027e7b80d43b1942893e17deb8bed0540", [:mix], [{:hpax, "~> 0.1.1", [hex: :hpax, repo: "hexpm", optional: false]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:thousand_island, "~> 1.0", [hex: :thousand_island, repo: "hexpm", optional: false]}, {:websock, "~> 0.5", [hex: :websock, repo: "hexpm", optional: false]}], "hexpm", "35ddbdce7e8a2a3c6b5093f7299d70832a43ed2f4a1852885a61d334cab1b4ad"},
+  "bunt": {:hex, :bunt, "1.0.0", "081c2c665f086849e6d57900292b3a161727ab40431219529f13c4ddcf3e7a44", [:mix], [], "hexpm", "dc5f86aa08a5f6fa6b8096f0735c4e76d54ae5c9fa2c143e5a1fc7c1cd9bb6b5"},
   "castore": {:hex, :castore, "1.0.7", "b651241514e5f6956028147fe6637f7ac13802537e895a724f90bf3e36ddd1dd", [:mix], [], "hexpm", "da7785a4b0d2a021cd1292a60875a784b6caef71e76bf4917bdee1f390455cf5"},
+  "credo": {:hex, :credo, "1.7.7", "771445037228f763f9b2afd612b6aa2fd8e28432a95dbbc60d8e03ce71ba4446", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "8bc87496c9aaacdc3f90f01b7b0582467b69b4bd2441fe8aae3109d843cc2f2e"},
   "db_connection": {:hex, :db_connection, "2.6.0", "77d835c472b5b67fc4f29556dee74bf511bbafecdcaf98c27d27fa5918152086", [:mix], [{:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "c2f992d15725e721ec7fbc1189d4ecdb8afef76648c746a8e1cad35e3b8a35f3"},
   "decimal": {:hex, :decimal, "2.1.1", "5611dca5d4b2c3dd497dec8f68751f1f1a54755e8ed2a966c2633cf885973ad6", [:mix], [], "hexpm", "53cfe5f497ed0e7771ae1a475575603d77425099ba5faef9394932b35020ffcc"},
   "dns_cluster": {:hex, :dns_cluster, "0.1.3", "0bc20a2c88ed6cc494f2964075c359f8c2d00e1bf25518a6a6c7fd277c9b0c66", [:mix], [], "hexpm", "46cb7c4a1b3e52c7ad4cbe33ca5079fbde4840dedeafca2baf77996c2da1bc33"},
@@ -12,7 +14,7 @@
   "finch": {:hex, :finch, "0.18.0", "944ac7d34d0bd2ac8998f79f7a811b21d87d911e77a786bc5810adb75632ada4", [:mix], [{:castore, "~> 0.1 or ~> 1.0", [hex: :castore, repo: "hexpm", optional: false]}, {:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:mint, "~> 1.3", [hex: :mint, repo: "hexpm", optional: false]}, {:nimble_options, "~> 0.4 or ~> 1.0", [hex: :nimble_options, repo: "hexpm", optional: false]}, {:nimble_pool, "~> 0.2.6 or ~> 1.0", [hex: :nimble_pool, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "69f5045b042e531e53edc2574f15e25e735b522c37e2ddb766e15b979e03aa65"},
   "floki": {:hex, :floki, "0.36.2", "a7da0193538c93f937714a6704369711998a51a6164a222d710ebd54020aa7a3", [:mix], [], "hexpm", "a8766c0bc92f074e5cb36c4f9961982eda84c5d2b8e979ca67f5c268ec8ed580"},
   "gettext": {:hex, :gettext, "0.24.0", "6f4d90ac5f3111673cbefc4ebee96fe5f37a114861ab8c7b7d5b30a1108ce6d8", [:mix], [{:expo, "~> 0.5.1", [hex: :expo, repo: "hexpm", optional: false]}], "hexpm", "bdf75cdfcbe9e4622dd18e034b227d77dd17f0f133853a1c73b97b3d6c770e8b"},
-  "heroicons": {:git, "https://github.com/tailwindlabs/heroicons.git", "88ab3a0d790e6a47404cba02800a6b25d2afae50", [tag: "v2.1.1", sparse: "optimized", depth: 1]},
+  "heroicons": {:git, "https://github.com/tailwindlabs/heroicons.git", "88ab3a0d790e6a47404cba02800a6b25d2afae50", [tag: "v2.1.1", sparse: "optimized"]},
   "hpax": {:hex, :hpax, "0.1.2", "09a75600d9d8bbd064cdd741f21fc06fc1f4cf3d0fcc335e5aa19be1a7235c84", [:mix], [], "hexpm", "2c87843d5a23f5f16748ebe77969880e29809580efdaccd615cd3bed628a8c13"},
   "jason": {:hex, :jason, "1.4.1", "af1504e35f629ddcdd6addb3513c3853991f694921b1b9368b0bd32beb9f1b63", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "fbb01ecdfd565b56261302f7e1fcc27c4fb8f32d56eab74db621fc154604a7a1"},
   "meeseeks": {:hex, :meeseeks, "0.17.0", "8a41ceccd2365476c2b779292e7649fb25f0a9735030905941f1244d2095c8a6", [:mix], [{:meeseeks_html5ever, "~> 0.14.3", [hex: :meeseeks_html5ever, repo: "hexpm", optional: false]}], "hexpm", "13efaf321a1517dea046cb48ff9baa9dc0604d9afd82c57501bc01dc45a5e309"},